Skip to content

Fix handling of powerview stale state #70195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 4 commits into from
Apr 18, 2022
Merged

Fix handling of powerview stale state #70195

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
819d258
Fix handling of powerview stale state
bdraco Apr 17, 2022
904452c
Update homeassistant/components/hunterdouglas_powerview/cover.py
bdraco Apr 17, 2022
35e6b14
tweak
bdraco Apr 17, 2022
15d0c05
tweak
bdraco Apr 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions homeassistant/components/hunterdouglas_powerview/cover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,12 @@

# Estimated time it takes to complete a transition
# from one state to another
TRANSITION_COMPLETE_DURATION = 30
TRANSITION_COMPLETE_DURATION = 40

PARALLEL_UPDATES = 1

RESYNC_DELAY = 60


async def async_setup_entry(
hass: HomeAssistant, entry: ConfigEntry, async_add_entities: AddEntitiesCallback
Expand Down Expand Up @@ -100,6 +102,9 @@ def hass_position_to_hd(hass_position):
class PowerViewShade(ShadeEntity, CoverEntity):
"""Representation of a powerview shade."""

# The hub frequently reports stale states
_attr_assumed_state = True

def __init__(self, coordinator, device_info, room_name, shade, name):
"""Initialize the shade."""
super().__init__(coordinator, device_info, room_name, shade, name)
Expand All @@ -116,6 +121,7 @@ def __init__(self, coordinator, device_info, room_name, shade, name):
)
if self._device_info[DEVICE_MODEL] != LEGACY_DEVICE_MODEL:
self._attr_supported_features |= CoverEntityFeature.STOP
self._forced_resync = None

@property
def extra_state_attributes(self):
Expand Down Expand Up @@ -220,10 +226,12 @@ def _async_update_current_cover_position(self):
@callback
def _async_cancel_scheduled_transition_update(self):
"""Cancel any previous updates."""
if not self._scheduled_transition_update:
return
self._scheduled_transition_update()
self._scheduled_transition_update = None
if self._scheduled_transition_update:
self._scheduled_transition_update()
self._scheduled_transition_update = None
if self._forced_resync:
self._forced_resync()
self._forced_resync = None

@callback
def _async_schedule_update_for_transition(self, steps):
Expand Down Expand Up @@ -256,6 +264,14 @@ async def _async_complete_schedule_update(self, _):
_LOGGER.debug("Processing scheduled update for %s", self.name)
self._scheduled_transition_update = None
await self._async_force_refresh_state()
self._forced_resync = async_call_later(
self.hass, RESYNC_DELAY, self._async_force_resync
)

async def _async_force_resync(self, *_):
"""Force a resync after an update since the hub may have stale state."""
self._forced_resync = None
await self._async_force_refresh_state()

async def _async_force_refresh_state(self):
"""Refresh the cover state and force the device cache to be bypassed."""
Expand All @@ -270,10 +286,14 @@ async def async_added_to_hass(self):
self.coordinator.async_add_listener(self._async_update_shade_from_group)
)

async def async_will_remove_from_hass(self):
"""Cancel any pending refreshes."""
self._async_cancel_scheduled_transition_update()

@callback
def _async_update_shade_from_group(self):
"""Update with new data from the coordinator."""
if self._scheduled_transition_update:
if self._scheduled_transition_update or self._forced_resync:
# If a transition in in progress
# the data will be wrong
return
Expand Down