Add missing AEMET weather units

[Noltari]

Breaking change

AEMET weather pressure and wind speed were reported with the default units which didn't match the real units of those weather attributes (Pa vs hPa and m/s vs km/h).

Proposed change

Add missing AEMET weather units: #68619
Also add myself back to CODEOWNERS.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #AEMET OpenData weather entity does not show units correctly. They are correct in sensor values #68619
• This PR is related to issue: AEMET OpenData weather entity does not show units correctly. They are correct in sensor values #68619
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[Kane610]

Looks good!

Should this be considered a breaking change since it affects data output?

[Noltari]

Looks good!

Should this be considered a breaking change since it affects data output?

Changed to a Breaking change.

[Noltari]

@frenck @Kane610 can you remove the bugfix label and add the breaking-change label?

[MatthewFlamm]

This seems to be the same or very similar to #61471, which was not accepted.

[Noltari]

This seems to be the same or very similar to #61471, which was not accepted.

As far as I know, #61471 became stale so it wasn't strictly rejected.
Also _attr_wind_speed_unit in that PR was wrong and it changed the hass.config.units.pressure_unit for the tests.
The default _attr_precipitation_unit matches the unit provided by AEMET (PRECIPITATION_MILLIMETERS_PER_HOUR).
In this case I'm only adding the units that differ with the original units reported by AEMET OpenData.

[bdraco]

While the code looks fine, I didn't merge because I want to understand all the history of this comment #61471 (comment) and how it affects this PR first

[Noltari]

While the code looks fine, I didn't merge because I want to understand all the history of this comment #61471 (comment) and how it affects this PR first

Seems that those other mentioned integrations were changing the weather attributes units to the ones wanted for each integration "localization".
However, the AEMET integration is currently reporting values in hPa and km/h and this value is being assigned to the default units (Pa and m/s) without any conversion. Therefore, if AEMET is reporting for example a wind speed 15 km/h, right now this is displayed on the UI as 15 m/s, which is wrong and should be 4.17 m/s. And the same goes for pressure, if the value reported by AEMET is 1004.4 hPa, it is being displayed by the UI as 1004.4 Pa, which is wrong and should be 100440 Pa.

So, AFAIK, there are 2 issues here:

1. Reporting weather attributes with the incorrect unit.
2. Forcing the UI to display the weather attributes in the units typical of the integration "localization" (example: wind speed in km/h vs m/s vs knots).

[MatthewFlamm]

There is some discussion here:

#60831 (comment)

[Noltari]

There is some discussion here:

#60831 (comment)

Ok, so the problem was generated by #59533 in the first place...

[javierabion]

While the code looks fine, I didn't merge because I want to understand all the history of this comment #61471 (comment) and how it affects this PR first

Hello @bdraco : ¿Any news on this merge?

[bdraco]

Nope. Haven't had time to look into it

[bdraco]

I spent a while reading the old PRs.

I think they are a bit of a red herring in this case as it looks like this is simply correcting the units to match how the api is reporting them.