Bugfix time and task coro#6968
Merged
Merged
Conversation
Contributor
|
I was working on the same thing. You can feel free to take the |
Member
|
Both look good and pretty much the same. Merging this, thanks to both of you! I will add a test shortly |
balloob
pushed a commit
that referenced
this pull request
Apr 8, 2017
* Bugfix time and task coro * fix also other create_task * fix tests * fix lint in test
Member
|
Cherry-picked into the 0.42 branch |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I think the right way to task a coro is with our
fire_coroutine_threadsafe. It fix also the create timer.