Preserve customize glob order.#6963
Merged
Merged
Conversation
|
@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jnewland, @balloob and @turbokongen to be potential reviewers. |
Member
|
Should we add a test to verify that we won't break this in the future? |
Contributor
Author
|
Added tests |
Member
|
Awesome, thanks. For the future, prefer to use test functions instead of test classes. |
balloob
pushed a commit
that referenced
this pull request
Apr 8, 2017
* Preserve customize glob order. * add tests
Member
|
Cherry-picked into the 0.42 branch |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Preserve customize glob order.
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass