Skip to content

Migrate upb light to color_mode #69524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emontnemery merged 3 commits into from
Apr 7, 2022
Merged

Migrate upb light to color_mode #69524

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
961064a
Migrate upb light to color_mode
epenet Apr 7, 2022
ba08794
Add supported_color_modes
epenet Apr 7, 2022
6c5d28c
Apply code review
epenet Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions homeassistant/components/upb/light.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
ATTR_BRIGHTNESS,
ATTR_FLASH,
ATTR_TRANSITION,
SUPPORT_BRIGHTNESS,
COLOR_MODE_BRIGHTNESS,
COLOR_MODE_ONOFF,
SUPPORT_FLASH,
SUPPORT_TRANSITION,
LightEntity,
Expand Down Expand Up @@ -55,11 +56,23 @@ def __init__(self, element, unique_id, upb):
super().__init__(element, unique_id, upb)
self._brightness = self._element.status

@property
def color_mode(self) -> str:
"""Return the color mode of the light."""
if self._element.dimmable:
return COLOR_MODE_BRIGHTNESS
return COLOR_MODE_ONOFF

@property
def supported_color_modes(self) -> set[str]:
"""Flag supported color modes."""
return {self.color_mode}

@property
def supported_features(self):
"""Flag supported features."""
if self._element.dimmable:
return SUPPORT_BRIGHTNESS | SUPPORT_TRANSITION | SUPPORT_FLASH
return SUPPORT_TRANSITION | SUPPORT_FLASH
return SUPPORT_FLASH

@property
Expand Down