Fix startup of sonos / snapshot handling / error handling#6945
Merged
Conversation
|
@pvizeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rhooper, @valentinalexeev and @fabaff to be potential reviewers. |
balloob
reviewed
Apr 5, 2017
| @asyncio.coroutine | ||
| def async_added_to_hass(self): | ||
| """Subscribe sonos events.""" | ||
| self._subscribe_to_player_events() |
Member
There was a problem hiding this comment.
Is this async safe? The function isn't annotated
Member
Author
There was a problem hiding this comment.
I look deeper into SoCo code and see that is not a good idea to run it inside loop. I move it into executor.
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: