Skip to content

Add EntityFeature enum to Humidifier#69092

Merged
frenck merged 1 commit intodevfrom
frenck-2022-0810
Apr 1, 2022
Merged

Add EntityFeature enum to Humidifier#69092
frenck merged 1 commit intodevfrom
frenck-2022-0810

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Apr 1, 2022

Breaking change

Developers only: The use of the following constants has been deprecated:

  • SUPPORT_MODES

Use the new HumidifierEntityFeature IntEnum instead.

Proposed change

This PR introduces the HumidifierEntityFeature, containing all the supported feature flags of a Humidifier.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (demo) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration (humidifier) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck marked this pull request as ready for review April 1, 2022 16:49
@frenck frenck requested a review from a team as a code owner April 1, 2022 16:49
Copy link
Copy Markdown
Contributor

@Shulyaka Shulyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@frenck frenck merged commit 02dbd61 into dev Apr 1, 2022
@frenck frenck deleted the frenck-2022-0810 branch April 1, 2022 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants