Skip to content

Options are required in select selector if custom_value is False#68983

Closed
raman325 wants to merge 2 commits intohome-assistant:devfrom
raman325:select_selector
Closed

Options are required in select selector if custom_value is False#68983
raman325 wants to merge 2 commits intohome-assistant:devfrom
raman325:select_selector

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Mar 31, 2022

Proposed change

As mentioned here: #68952 (comment)

It only makes sense to not provide options when custom_value is True, and I think it's better to require that at least one option is included if options is specified. This preserves the original behavior when custom_value is False but allows options to not be provided when custom_value is True.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (utility_meter) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@dgomes
Copy link
Copy Markdown
Contributor

dgomes commented Mar 31, 2022

CC @emontnemery

@raman325 raman325 added this to the 2022.4.0 milestone Mar 31, 2022
@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 31, 2022

As selectors are now usable by the backend: If the backend doesn't have an option to present (whatever the reason), it would break instead of listing no options.

That is why its OK to have an empty list.

@raman325 raman325 closed this Mar 31, 2022
@raman325 raman325 deleted the select_selector branch March 31, 2022 14:48
@balloob balloob removed this from the 2022.4.0 milestone Mar 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants