Options are required in select selector if custom_value is False#68983
Closed
raman325 wants to merge 2 commits intohome-assistant:devfrom
Closed
Options are required in select selector if custom_value is False#68983raman325 wants to merge 2 commits intohome-assistant:devfrom
raman325 wants to merge 2 commits intohome-assistant:devfrom
Conversation
|
Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration ( |
8 tasks
Contributor
|
CC @emontnemery |
Member
|
As selectors are now usable by the backend: If the backend doesn't have an option to present (whatever the reason), it would break instead of listing no options. That is why its OK to have an empty list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
As mentioned here: #68952 (comment)
It only makes sense to not provide options when
custom_valueisTrue, and I think it's better to require that at least one option is included ifoptionsis specified. This preserves the original behavior whencustom_valueisFalsebut allows options to not be provided whencustom_valueisTrue.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: