Added average temperature for the day before and the current period#6883
Merged
Conversation
|
@diogos88, thanks for your PR! By analyzing the history of the files in this pull request, we identified @titilambert to be a potential reviewer. |
Contributor
houndci-bot
reviewed
Apr 2, 2017
| 'yesterday_lower_price_consumption': ['Yesterday lower price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_higher_price_consumption': ['Yesterday higher price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_average_temperature': ['Yesterday average temperature', TEMP_CELSIUS, 'mdi:thermometer'], | ||
| 'period_average_temperature': ['Period average temperature', TEMP_CELSIUS, 'mdi:thermometer'], |
| 'yesterday_total_consumption': ['Yesterday total consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_lower_price_consumption': ['Yesterday lower price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_higher_price_consumption': ['Yesterday higher price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_average_temperature': ['Yesterday average temperature', TEMP_CELSIUS, 'mdi:thermometer'], |
There was a problem hiding this comment.
line too long (104 > 79 characters)
| 'period_higher_price_consumption': ['Period Higher price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_total_consumption': ['Yesterday total consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_lower_price_consumption': ['Yesterday lower price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_higher_price_consumption': ['Yesterday higher price consumption', KILOWATT_HOUR, 'mdi:flash'], |
There was a problem hiding this comment.
line too long (109 > 79 characters)
| 'period_lower_price_consumption': ['Period Lower price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_higher_price_consumption': ['Period Higher price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_total_consumption': ['Yesterday total consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_lower_price_consumption': ['Yesterday lower price consumption', KILOWATT_HOUR, 'mdi:flash'], |
There was a problem hiding this comment.
line too long (107 > 79 characters)
| 'period_total_consumption': ['Total Consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_lower_price_consumption': ['Period Lower price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_higher_price_consumption': ['Period Higher price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_total_consumption': ['Yesterday total consumption', KILOWATT_HOUR, 'mdi:flash'], |
| 'period_mean_daily_bill': ['Period daily average bill', PRICE, 'mdi:square-inc-cash'], | ||
| 'period_mean_daily_consumption': ['Period daily average consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_total_consumption': ['Total Consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_lower_price_consumption': ['Period Lower price consumption', KILOWATT_HOUR, 'mdi:flash'], |
There was a problem hiding this comment.
line too long (101 > 79 characters)
| 'period_total_days': ['Total number of days in this period', DAYS, 'mdi:calendar-today'], | ||
| 'period_mean_daily_bill': ['Period daily average bill', PRICE, 'mdi:square-inc-cash'], | ||
| 'period_mean_daily_consumption': ['Period daily average consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_total_consumption': ['Total Consumption', KILOWATT_HOUR, 'mdi:flash'], |
| 'period_length': ['Current period length', DAYS, 'mdi:calendar-today'], | ||
| 'period_total_days': ['Total number of days in this period', DAYS, 'mdi:calendar-today'], | ||
| 'period_mean_daily_bill': ['Period daily average bill', PRICE, 'mdi:square-inc-cash'], | ||
| 'period_mean_daily_consumption': ['Period daily average consumption', KILOWATT_HOUR, 'mdi:flash'], |
There was a problem hiding this comment.
line too long (102 > 79 characters)
| 'period_total_bill': ['Current period bill', PRICE, 'mdi:square-inc-cash'], | ||
| 'period_length': ['Current period length', DAYS, 'mdi:calendar-today'], | ||
| 'period_total_days': ['Total number of days in this period', DAYS, 'mdi:calendar-today'], | ||
| 'period_mean_daily_bill': ['Period daily average bill', PRICE, 'mdi:square-inc-cash'], |
| ['Yesterday higher price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_total_bill': ['Current period bill', PRICE, 'mdi:square-inc-cash'], | ||
| 'period_length': ['Current period length', DAYS, 'mdi:calendar-today'], | ||
| 'period_total_days': ['Total number of days in this period', DAYS, 'mdi:calendar-today'], |
houndci-bot
reviewed
Apr 2, 2017
| 'yesterday_average_temperature': | ||
| ['Yesterday average temperature', TEMP_CELSIUS, 'mdi:thermometer'], | ||
| 'period_average_temperature': | ||
| ['Period average temperature', TEMP_CELSIUS, 'mdi:thermometer'], |
There was a problem hiding this comment.
indentation contains tabs
indentation contains mixed spaces and tabs
| ['Yesterday higher price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_average_temperature': | ||
| ['Yesterday average temperature', TEMP_CELSIUS, 'mdi:thermometer'], | ||
| 'period_average_temperature': |
There was a problem hiding this comment.
indentation contains mixed spaces and tabs
trailing whitespace
| 'yesterday_higher_price_consumption': | ||
| ['Yesterday higher price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_average_temperature': | ||
| ['Yesterday average temperature', TEMP_CELSIUS, 'mdi:thermometer'], |
There was a problem hiding this comment.
indentation contains tabs
indentation contains mixed spaces and tabs
| ['Yesterday lower price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_higher_price_consumption': | ||
| ['Yesterday higher price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_average_temperature': |
There was a problem hiding this comment.
indentation contains mixed spaces and tabs
trailing whitespace
| 'yesterday_lower_price_consumption': | ||
| ['Yesterday lower price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_higher_price_consumption': | ||
| ['Yesterday higher price consumption', KILOWATT_HOUR, 'mdi:flash'], |
There was a problem hiding this comment.
indentation contains tabs
indentation contains mixed spaces and tabs
| ['Total Consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_lower_price_consumption': | ||
| ['Period Lower price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_higher_price_consumption': |
There was a problem hiding this comment.
indentation contains mixed spaces and tabs
trailing whitespace
| 'period_total_consumption': | ||
| ['Total Consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_lower_price_consumption': | ||
| ['Period Lower price consumption', KILOWATT_HOUR, 'mdi:flash'], |
There was a problem hiding this comment.
indentation contains tabs
indentation contains mixed spaces and tabs
| ['Period daily average consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_total_consumption': | ||
| ['Total Consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_lower_price_consumption': |
There was a problem hiding this comment.
indentation contains mixed spaces and tabs
trailing whitespace
| 'period_mean_daily_consumption': | ||
| ['Period daily average consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_total_consumption': | ||
| ['Total Consumption', KILOWATT_HOUR, 'mdi:flash'], |
There was a problem hiding this comment.
indentation contains tabs
indentation contains mixed spaces and tabs
| ['Period daily average bill', PRICE, 'mdi:square-inc-cash'], | ||
| 'period_mean_daily_consumption': | ||
| ['Period daily average consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_total_consumption': |
There was a problem hiding this comment.
indentation contains mixed spaces and tabs
trailing whitespace
…ces and tabs" warnings
houndci-bot
reviewed
Apr 2, 2017
| ['Yesterday higher price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_average_temperature': | ||
| ['Yesterday average temperature', TEMP_CELSIUS, 'mdi:thermometer'], | ||
| 'period_average_temperature': |
| ['Yesterday lower price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_higher_price_consumption': | ||
| ['Yesterday higher price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_average_temperature': |
| ['Yesterday total consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_lower_price_consumption': | ||
| ['Yesterday lower price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_higher_price_consumption': |
| ['Period Higher price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_total_consumption': | ||
| ['Yesterday total consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_lower_price_consumption': |
| ['Period Lower price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_higher_price_consumption': | ||
| ['Period Higher price consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_total_consumption': |
| ['Total number of days in this period', DAYS, 'mdi:calendar-today'], | ||
| 'period_mean_daily_bill': | ||
| ['Period daily average bill', PRICE, 'mdi:square-inc-cash'], | ||
| 'period_mean_daily_consumption': |
| ['Current period length', DAYS, 'mdi:calendar-today'], | ||
| 'period_total_days': | ||
| ['Total number of days in this period', DAYS, 'mdi:calendar-today'], | ||
| 'period_mean_daily_bill': |
| ['Current period bill', PRICE, 'mdi:square-inc-cash'], | ||
| 'period_length': | ||
| ['Current period length', DAYS, 'mdi:calendar-today'], | ||
| 'period_total_days': |
| 'yesterday_higher_price_consumption': | ||
| 'period_total_bill': | ||
| ['Current period bill', PRICE, 'mdi:square-inc-cash'], | ||
| 'period_length': |
| 'yesterday_lower_price_consumption': ['Yesterday lower price consumption', | ||
| KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_higher_price_consumption': | ||
| 'period_total_bill': |
houndci-bot
reviewed
Apr 2, 2017
| ['Period daily average bill', PRICE, 'mdi:square-inc-cash'], | ||
| 'period_mean_daily_consumption': | ||
| ['Period daily average consumption', KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_total_consumption': |
| ['Total number of days in this period', DAYS, 'mdi:calendar-today'], | ||
| 'period_mean_daily_bill': | ||
| ['Period daily average bill', PRICE, 'mdi:square-inc-cash'], | ||
| 'period_mean_daily_consumption': |
| ['Current period length', DAYS, 'mdi:calendar-today'], | ||
| 'period_total_days': | ||
| ['Total number of days in this period', DAYS, 'mdi:calendar-today'], | ||
| 'period_mean_daily_bill': |
| ['Current period bill', PRICE, 'mdi:square-inc-cash'], | ||
| 'period_length': | ||
| ['Current period length', DAYS, 'mdi:calendar-today'], | ||
| 'period_total_days': |
| KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_total_bill': | ||
| ['Current period bill', PRICE, 'mdi:square-inc-cash'], | ||
| 'period_length': |
| KILOWATT_HOUR, 'mdi:flash'], | ||
| 'yesterday_lower_price_consumption': ['Yesterday lower price consumption', | ||
| KILOWATT_HOUR, 'mdi:flash'], | ||
| 'period_total_bill': |
Contributor
Author
|
I don't see any trailing whitespace in the last push. What I am missing that houndci-bot see? |
Contributor
|
@diogos88 sometimes hound doesn't close its own comments |
Member
|
Docs PR: home-assistant/home-assistant.io#2370 BTW, the PR template helps to keep track... |
Merged
ghost
removed
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: