Skip to content

Lifx legacy#6847

Merged
balloob merged 4 commits into
home-assistant:devfrom
amelchio:lifx-legacy
Mar 30, 2017
Merged

Lifx legacy#6847
balloob merged 4 commits into
home-assistant:devfrom
amelchio:lifx-legacy

Conversation

@amelchio
Copy link
Copy Markdown
Contributor

@amelchio amelchio commented Mar 29, 2017

Description:

Related issue (if applicable): fixes #6820

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2353

Example entry for configuration.yaml (if applicable):

light:
  platform: lifx_legacy

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully.
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

The async platform introduced in 9ef084d has
turned out to use Python functionality that is not available in Windows.

This commit restores the previous implementation, now named lifx_legacy.
@balloob balloob added this to the 0.41.1 milestone Mar 30, 2017
@balloob balloob merged commit 7b83a83 into home-assistant:dev Mar 30, 2017
@fabaff fabaff mentioned this pull request Apr 6, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LIFX broken on Windows in HA 0.41

4 participants