Raise if referenced entity does not support service#68394
Merged
Conversation
Member
Author
|
Was able to fix all tests except for 1: Template Alarm Control Panel will only add supported_features for features it has a script defined for. However it does allow calling unsupported methods: the entity will update it's state but also log an error (source / test). I think that we should fix this behavior in template alarm control panel. Two options:
I went for 2 because the supported feature was not there, causing it to already be skipped. |
elupus
reviewed
Mar 20, 2022
Contributor
elupus
left a comment
There was a problem hiding this comment.
I very much like this change. I don't like the silent errors. Maybe a specialized exception should be used for the not supported case?
chemelli74
approved these changes
Mar 20, 2022
Contributor
chemelli74
left a comment
There was a problem hiding this comment.
Looks fine for SamsungTV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
If an entity is explicitly referenced as a target for a service that the entity doesn't support, we now raise an error instead of silently ignoring it.
Proposed change
If an entity is explicitly referenced for a service but the entity does not contain the supported_feature, raise an error instead of silently ignoring it.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: