Skip to content

Handle Hue discovery errors#68392

Merged
balloob merged 1 commit intodevfrom
hue-config-flow-handle-error
Mar 19, 2022
Merged

Handle Hue discovery errors#68392
balloob merged 1 commit intodevfrom
hue-config-flow-handle-error

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Mar 19, 2022

Breaking change

Proposed change

Fixes #68388

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @marcelveldt, mind taking a look at this pull request as it has been labeled with an integration (hue) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 19, 2022

ServerDisconnectedError: seems like it can happen here as well https://github.com/home-assistant-libs/aiohue/blob/master/aiohue/v2/__init__.py#L144

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 19, 2022

Looks like this will work for discovery 👍

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Mar 19, 2022

@marcelveldt it looks like we currently don't do any error handling. Should we wrap aiohttp and aiohue errors in HomeAssitantErrors here: https://github.com/home-assistant/core/blob/dev/homeassistant/components/hue/bridge.py#L119 ? Or should we make another wrapper.

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Mar 19, 2022

Merging this so we can do the other in a follow-up PR.

@balloob balloob merged commit ead81ed into dev Mar 19, 2022
@balloob balloob deleted the hue-config-flow-handle-error branch March 19, 2022 21:28
@balloob balloob mentioned this pull request Mar 19, 2022
22 tasks
@balloob
Copy link
Copy Markdown
Member Author

balloob commented Mar 19, 2022

Opened #68396

@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hue integration does not handle ServerDisconnectedError exceptions

4 participants