Skip to content

Mark stream available on idle timeout#68380

Merged
allenporter merged 1 commit intohome-assistant:devfrom
allenporter:stream-available
Mar 19, 2022
Merged

Mark stream available on idle timeout#68380
allenporter merged 1 commit intohome-assistant:devfrom
allenporter:stream-available

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

@allenporter allenporter commented Mar 19, 2022

Proposed change

Mark stream as available on idle timeout so that the frontend can still interact with it. In particular, the Frontend won't interact with camera objects that are not available e.g. from picture glance card.

I tested this manually with tcpkill to break the stream, but not add tests since we don't have any existing idle timeout tests due to raciness.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Mark stream as available on idle timeout so that the frontend can
still interact with it. In particular, the Frontend won't interact
with camera objects that are not available e.g. from picture glance
card.

Issue home-assistant#67922
@probot-home-assistant
Copy link
Copy Markdown

Hey there @hunterjm, @uvjustin, mind taking a look at this pull request as it has been labeled with an integration (stream) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@allenporter allenporter merged commit 5027e1b into home-assistant:dev Mar 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2022
@allenporter allenporter deleted the stream-available branch July 9, 2022 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Camera video playback fails after error on stream

4 participants