Add zha typing [api] (3)#68353
Merged
dmulcahey merged 3 commits intohome-assistant:devfrom Mar 22, 2022
Merged
Conversation
|
Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration ( |
dmulcahey
approved these changes
Mar 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Continue typing
zha/api.py.Followup to #68335 (review)
IEEEfields.EUI64.convertcan returnEUI64 | None.https://github.com/zigpy/zigpy/blob/0.43.0/zigpy/types/named.py#L28-L34
convert_install_codeandqr_to_install_code. Both functions just assume a string is passed as input.default=Noneforvol.Optional(ATTR_IEEE). Both the websocket endpoint and the permit service use.get(ATTR_IEEE)to access the attribute. In all other cases, theIEEEvalues are required.warning_device_warnservice data.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: