Skip to content

Redact data from zwave_js diagnostics #68348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raman325 merged 2 commits into from
Mar 19, 2022
Merged

Redact data from zwave_js diagnostics #68348

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee87901
Redact home ID and location from zwave_js diagnostics
raman325 Mar 18, 2022
7f6645a
Switch to set
raman325 Mar 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions homeassistant/components/zwave_js/diagnostics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from zwave_js_server.dump import dump_msgs
from zwave_js_server.model.node import NodeDataType

from homeassistant.components.diagnostics.util import async_redact_data
from homeassistant.config_entries import ConfigEntry
from homeassistant.const import CONF_URL
from homeassistant.core import HomeAssistant
Expand All @@ -14,6 +15,8 @@
from .const import DATA_CLIENT, DOMAIN
from .helpers import get_home_and_node_id_from_device_entry

TO_REDACT = ("homeId", "location")


async def async_get_config_entry_diagnostics(
hass: HomeAssistant, config_entry: ConfigEntry
Expand All @@ -22,7 +25,7 @@ async def async_get_config_entry_diagnostics(
msgs: list[dict] = await dump_msgs(
config_entry.data[CONF_URL], async_get_clientsession(hass)
)
return msgs
return async_redact_data(msgs, TO_REDACT)


async def async_get_device_diagnostics(
Expand All @@ -42,5 +45,5 @@ async def async_get_device_diagnostics(
"minSchemaVersion": client.version.min_schema_version,
"maxSchemaVersion": client.version.max_schema_version,
},
"state": node.data,
"state": async_redact_data(node.data, TO_REDACT),
}