Skip to content

Cache parsing attr in LazyState#68232

Merged
balloob merged 5 commits intohome-assistant:devfrom
bdraco:cache_attributes_parse
Mar 18, 2022
Merged

Cache parsing attr in LazyState#68232
balloob merged 5 commits intohome-assistant:devfrom
bdraco:cache_attributes_parse

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 16, 2022

Proposed change

Parsing attributes in the most expensive part of loading a LazyState

This speeds up history requests for entities where cannot use minimal_response or are in NEED_ATTRIBUTE_DOMAINS

On a few of my production instances attributes ranged from 82-88% duplicates of another set of attributes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco marked this pull request as ready for review March 16, 2022 19:29
@bdraco bdraco requested a review from a team as a code owner March 16, 2022 19:29
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 17, 2022
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 18, 2022

Marking this as a draft until #68224 merges since this one will be easier to resolve the impending conflict

@bdraco bdraco marked this pull request as draft March 18, 2022 09:15
@bdraco bdraco marked this pull request as ready for review March 18, 2022 10:34
@balloob balloob merged commit 9864090 into home-assistant:dev Mar 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality core integration: recorder small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants