Skip to content

Add support for menu step#68203

Merged
balloob merged 4 commits intodevfrom
data-entry-flow-menu
Mar 16, 2022
Merged

Add support for menu step#68203
balloob merged 4 commits intodevfrom
data-entry-flow-menu

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Mar 15, 2022

Breaking change

Proposed change

Add support for a menu step in a data entry flow to help the user navigating to different options.

When menu_options is a:

  • list of step IDs: labels are translated via strings.json and supports placeholders
  • dictionary: step_id => label
CleanShot.2022-03-15.at.12.55.42.mp4

Frontend PR: home-assistant/frontend#12055

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob marked this pull request as ready for review March 15, 2022 21:21
@balloob balloob requested a review from a team as a code owner March 15, 2022 21:21
Copy link
Copy Markdown
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a cursory look. Should be useful to have.

@balloob balloob merged commit f6af93a into dev Mar 16, 2022
@balloob balloob deleted the data-entry-flow-menu branch March 16, 2022 21:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants