WIP: Mqtt discovery updates rework#67912
Closed
jbouwh wants to merge 2 commits intohome-assistant:devfrom
Closed
Conversation
|
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( |
4b9768f to
afd7a37
Compare
75a8e00 to
0952f3f
Compare
jbouwh
added a commit
to jbouwh/core
that referenced
this pull request
Mar 12, 2022
22 tasks
jbouwh
added a commit
to jbouwh/core
that referenced
this pull request
Mar 12, 2022
* Move notify serviceupdater to Mixins * Move tag discovery handler to Mixins * fix tests
Contributor
Author
|
This PR is superseded by #67966. |
jbouwh
added a commit
to jbouwh/core
that referenced
this pull request
Mar 12, 2022
* Move notify serviceupdater to Mixins * Move tag discovery handler to Mixins * fix tests
jbouwh
added a commit
to jbouwh/core
that referenced
this pull request
Mar 12, 2022
* Move notify serviceupdater to Mixins * Move tag discovery handler to Mixins * fix tests
jbouwh
added a commit
to jbouwh/core
that referenced
this pull request
Mar 13, 2022
* Move notify serviceupdater to Mixins * Move tag discovery handler to Mixins * fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Code for handling MQTT discovery updates for platforms without entities was specialized for
notify.taganddevice_automation. This PR moves the discovery logic and device updates to a centralized place.For
notifythe discovery topic is now reset when the device is removed to avoid rediscovery after a restart.This was already implemented for the
tagplatform.DONE:
notfifyandtagTODO:
device_automationType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: