Update Insight parameters using the subscription data.#6782
Merged
Conversation
houndci-bot
reviewed
Mar 25, 2017
| except AttributeError: | ||
| _LOGGER.warning('Could not update status for %s', self.name) | ||
| except AttributeError as err: | ||
| _LOGGER.warning('Could not update status for %s (%s)', self.name, err) |
There was a problem hiding this comment.
line too long (82 > 79 characters)
houndci-bot
reviewed
Mar 25, 2017
| _LOGGER.warning('Could not update status for %s', self.name) | ||
| except AttributeError as err: | ||
| _LOGGER.warning('Could not update status for %s (%s)', | ||
| self.name, err) |
There was a problem hiding this comment.
continuation line under-indented for visual indent
Contributor
Author
|
@stu-gott Thanks for your super fast feedback on the |
pvizeli
approved these changes
Mar 27, 2017
Merged
ghost
removed
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The subscription model of the wemo insight switch worked by receiving an alert when the state changed - HA then went to fetch the updated data.
The recent change to update power useage every second caused a lot more traffic - which on my unreliable network can lead to lost subscriptions.
This PR updates the pywemo library and the HA device so that the data in the wemo updates is used to directly update the device state - avoiding a round trip to the device.
Would be grateful for some help testing.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass