Skip to content

Fix bridge-led support in limitlessled.py#6776

Merged
pvizeli merged 1 commit into
home-assistant:devfrom
quadportnick:patch-2
Mar 25, 2017
Merged

Fix bridge-led support in limitlessled.py#6776
pvizeli merged 1 commit into
home-assistant:devfrom
quadportnick:patch-2

Conversation

@quadportnick
Copy link
Copy Markdown
Contributor

@quadportnick quadportnick commented Mar 25, 2017

Addressing #6382 . Feedback from github & forums is the bridge_led feature never worked and defining the bridge LED as another group+bulb type is the right way to do this in the limitlessled component.

Description:

Removes bridge_led configuration and adds bridge-led as a type parameter

Related issue (if applicable): fixes #6382

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2329

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

N/A:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Addressing home-assistant#6382 . Feedback from github & forums is the bridge_led feature never worked and defining the bridge LED as another group+bulb type is the right way to do this in the limitlessled component.
@mention-bot
Copy link
Copy Markdown

@quadportnick, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @soldag and @happyleavesaoc to be potential reviewers.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @quadportnick,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LimitlessLED, bridge_led not showing up

4 participants