Tests for zwave workaround detection#6761
Merged
Merged
Conversation
|
@armills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers. |
emlove
commented
Mar 23, 2017
| def get_device_component_mapping(value): | ||
| """Get mapping of value to another component.""" | ||
| if (value.node.manufacturer_id.strip() and | ||
| value.node.product_type.strip()): |
Contributor
Author
There was a problem hiding this comment.
I don't think this was ever actually doing anything. strip() returns a stripped copy of the string. Since there's always a string object returned it always evaluates to true. It doesn't modify the original string.
Member
There was a problem hiding this comment.
Empty string is considered false:
But I don't know if manufacturer_id or product_type would ever return a string that is just whitespace.
Contributor
Author
There was a problem hiding this comment.
Ah, I must have messed something up when I tested it in the interpreter. I'll restore it then and add a test.
This reverts commit e06cce0.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
See #6437