Updating Alarm.com Component for async and no Selenium#6752
Merged
Conversation
Member
|
Not sure why the requirements test is failing 🤔 |
balloob
approved these changes
Mar 24, 2017
Member
balloob
left a comment
There was a problem hiding this comment.
🐬
ok to merge when tests pass.
Contributor
Author
|
So if I run the gen_requirements script it looks like it is trying to install the previous requirements instead of the update requirements. Is there something I am doing wrong? |
Contributor
Author
|
So as an FYI, my gen_all_requirements was failling because I had an actual version of home-assistant installed in my dev environment. Once I |
Contributor
Author
|
Is this okay to be merged even though it is stuck on the coverage/coveralls check? |
Member
|
Yep, ok to merge! 🐬 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Update Alarm.com component to remove PhantomJS/Selenium dependencies. Making it natively async.
Related issue (if applicable): fixes #4474, #2774
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.