Skip to content

Updating Alarm.com Component for async and no Selenium#6752

Merged
balloob merged 2 commits into
home-assistant:devfrom
lorddaren:alarmdotcom2
Mar 29, 2017
Merged

Updating Alarm.com Component for async and no Selenium#6752
balloob merged 2 commits into
home-assistant:devfrom
lorddaren:alarmdotcom2

Conversation

@lorddaren
Copy link
Copy Markdown
Contributor

Description:

Update Alarm.com component to remove PhantomJS/Selenium dependencies. Making it natively async.

Related issue (if applicable): fixes #4474, #2774

Example entry for configuration.yaml (if applicable):

alarm_control_panel:
  username: <alarm.com username>
  password: <alarm.com password>
  code: <internal alarm_control_panel code for HA>

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@mention-bot
Copy link
Copy Markdown

@Xorso, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @wardcraigj and @balloob to be potential reviewers.

@balloob
Copy link
Copy Markdown
Member

balloob commented Mar 24, 2017

Not sure why the requirements test is failing 🤔

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐬

ok to merge when tests pass.

@lorddaren
Copy link
Copy Markdown
Contributor Author

So if I run the gen_requirements script it looks like it is trying to install the previous requirements instead of the update requirements. Is there something I am doing wrong?

@lorddaren
Copy link
Copy Markdown
Contributor Author

So as an FYI, my gen_all_requirements was failling because I had an actual version of home-assistant installed in my dev environment. Once I pip uninstalled homeassistant and then python setup.py develop everything generated like it was supposed too. Let see if it passes now.

@lorddaren
Copy link
Copy Markdown
Contributor Author

Is this okay to be merged even though it is stuck on the coverage/coveralls check?

@balloob
Copy link
Copy Markdown
Member

balloob commented Mar 29, 2017

Yep, ok to merge! 🐬

@balloob balloob merged commit d1b519a into home-assistant:dev Mar 29, 2017
@fabaff fabaff mentioned this pull request Apr 6, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyalarmdotcom: Error while setting up platform

4 participants