Add device_info and entity_category to Vallox

[andre-richter]

Breaking change

Proposed change

Adds Device Registry and entity categorization support.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[probot-home-assistant]

Hey there @slovdahl, @viiru-, mind taking a look at this pull request as it has been labeled with an integration (vallox) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[andre-richter]

@slovdahl could you give me a quick primer on how to run all the vallox tests locally?

[slovdahl]

@slovdahl could you give me a quick primer on how to run all the vallox tests locally?

Sure! Are you using the devcontainers setup? In that case, run this:

pytest tests/components/vallox

And if you want to check the test coverage percentages, use this:

pytest --cov=homeassistant/components/vallox/ --cov-report term-missing -- tests/components/vallox/

[slovdahl]

Tested the changes briefly locally, seeems to work fine 👍

[andre-richter]

Thanks! Need to fix the Tests sometime later, hopefully today.

[slovdahl]

Thanks, nice improvement overall! I really like getting the direct link to the Vallox unit's web UI 🙂

[andre-richter]

@iMicknl I would like to defer the changes to the isinstance() checks to a follow up PR, since we currently have this pattern in other parts of ValloxState as well that are not touched by this PR.

Then we can do it all at once (or tackle it in the 3rd party library directly), and not mix it with the actual scope of this PR.

[iMicknl]

@iMicknl I would like to defer the changes to the isinstance() checks to a follow up PR, since we currently have this pattern in other parts of ValloxState as well that are not touched by this PR.

Then we can do it all at once (or tackle it in the 3rd party library directly), and not mix it with the actual scope of this PR.

Makes sense! I didn't look at the other parts of this component. For now; a quick fix could be to just use cast() instead of instanceof.

[andre-richter]

Did a major rebase because a few conflicting PRs went in in the meantime. @slovdahl would be great if you could do a smoke test again as well 🙏

[slovdahl]

Works like a charm 👍