Fix powerwall data incompatibility with energy integration#67245
Merged
frenck merged 4 commits intohome-assistant:devfrom Feb 25, 2022
Merged
Fix powerwall data incompatibility with energy integration#67245frenck merged 4 commits intohome-assistant:devfrom
frenck merged 4 commits intohome-assistant:devfrom
Conversation
|
Hey there @jrester, mind taking a look at this pull request as it has been labeled with an integration ( |
This reverts commit bf11aae.
frenck
approved these changes
Feb 25, 2022
bdraco
added a commit
to bdraco/home-assistant
that referenced
this pull request
Feb 26, 2022
While this fixed ``` 2022-02-25 18:35:21 WARNING (Recorder) [homeassistant.components.sensor.recorder] Entity sensor.powerwall_site_export from integration powerwall has state class total_increasing, but its state is negative. Triggered by state -47025.4 with last_updated set to 2022-02-25T18:29:59.999999+00:00. Please create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+powerwall%22 2022-02-25 18:35:21 WARNING (Recorder) [homeassistant.components.sensor.recorder] Entity sensor.powerwall_site_import from integration powerwall has state class total_increasing, but its state is negative. Triggered by state -33046.6 with last_updated set to 2022-02-25T18:29:59.999999+00:00. Please create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+powerwall%22 ``` This change broke net returned to grid. All battery energy is now showing returned to grid. It appears the frontend expects negative values but the datebase warns on them. Revert this change until more research can be done to determine a better solution.
balloob
pushed a commit
that referenced
this pull request
Feb 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Powerwall import and export sensors are reported now reported as positive values since any negative values are not compatible with state class total increasing.This is being reverted in #67300FixesWhen a value of 0 is reported, we now reject the data by reporting the state as unavailable. These are likely read failures.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests:
Fixes #67237