Add is_controller_node flag to WS node status#66404
Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom Feb 12, 2022
Merged
Add is_controller_node flag to WS node status#66404MartinHjelmare merged 1 commit intohome-assistant:devfrom
MartinHjelmare merged 1 commit intohome-assistant:devfrom
Conversation
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add the node's
is_controller_nodeflag to the WS node status message, which is used by the frontend to display device information. Theis_controller_nodeflag is True when a node is the "connected" z-wave controller. The meaning of "connected controller" refers to the controller that is being controlled by the driver via the serial API. Other controllers in the network (e.g. secondary) that interact by z-wave commands are not "connected" and this flag would be false for those.The frontend can use this flag to tailor information and actions based on whether the selected device is the connected controller or not (I have a change for that in progress). Many properties and actions for nodes are not valid for connected controllers and causes confusion with users. Common support questions are along the lines of "why doesn't my controller support z-wave plus or security?". These are examples of two properties that aren't available via the serial API and so displaying them incorrectly is misleading. With this flag the frontend is able to omit those properties.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, devicesweb services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: