Fix hydroquebec#6574
Merged
Merged
Conversation
|
I can confirm that this fix work on my environment! |
a1e44df to
7ed8b0f
Compare
Contributor
Author
|
@djfjeff I just changed the patch, could you confirm the new fix ? |
|
@titilambert Yes, confirm it's still working removing previous patch and using this one! |
pvizeli
approved these changes
Mar 13, 2017
|
Thanks you for the fix! It work well |
Member
|
Cherry-picked for 0.40.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Hello, @djfjeff got an error after the 0.40 upgrade. The issue is related to init stage where data had not been already collected (by the hydroquebec client) when they are requested by the component.
So the data attribute is empty.
Here the log from @djfjeff:
Related issue (if applicable): fixes #home-assistant/home-assistant.io#2191
Checklist:
toxrun successfully. Your PR cannot be merged unless tests pass