Skip to content

Move scene and button restore to internal hook#65696

Merged
balloob merged 2 commits intodevfrom
scene-internal-added-to-hass
Feb 4, 2022
Merged

Move scene and button restore to internal hook#65696
balloob merged 2 commits intodevfrom
scene-internal-added-to-hass

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 4, 2022

Breaking change

Proposed change

Move Scene entity state restore logic to async_internal_added_to_hass so scene entities that extend it are not forced to call super.async_added_to_hass() (as Hue forgot).

Related to #65655

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob requested a review from a team as a code owner February 4, 2022 17:43
@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (scene) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob changed the title Move scene restore to internal hook Move scene and button restore to internal hook Feb 4, 2022
@balloob balloob added this to the 2022.2.2 milestone Feb 4, 2022
@balloob balloob merged commit 2a8797a into dev Feb 4, 2022
@balloob balloob deleted the scene-internal-added-to-hass branch February 4, 2022 18:43
@balloob balloob mentioned this pull request Feb 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants