Skip to content

Allow selecting own repositories#65695

Merged
frenck merged 1 commit intodevfrom
github-own-repos
Feb 4, 2022
Merged

Allow selecting own repositories#65695
frenck merged 1 commit intodevfrom
github-own-repos

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Feb 4, 2022

Breaking change

Proposed change

While I personally don't agree with this, it has been mentioned so many times it should just be done.
example https://twitter.com/pvizeli/status/1489563199447912450

ludeeus/aiogithubapi@22.1.2...22.2.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @timmo001, mind taking a look at this pull request as it has been labeled with an integration (github) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@ludeeus ludeeus added this to the 2022.2.2 milestone Feb 4, 2022
@ludeeus ludeeus marked this pull request as ready for review February 4, 2022 18:05
@frenck frenck merged commit 8021b05 into dev Feb 4, 2022
@frenck frenck deleted the github-own-repos branch February 4, 2022 18:33
balloob pushed a commit that referenced this pull request Feb 4, 2022
@balloob balloob mentioned this pull request Feb 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants