Skip to content

Improve recorder migration for PostgreSQL when columns already exist #65680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 1 commit into from
Feb 4, 2022
Merged

Improve recorder migration for PostgreSQL when columns already exist #65680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions homeassistant/components/recorder/migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def _create_index(instance, table_name, index_name):
with session_scope(session=instance.get_session()) as session:
connection = session.connection()
index.create(connection)
except (InternalError, ProgrammingError, OperationalError) as err:
except (InternalError, OperationalError, ProgrammingError) as err:
raise_if_exception_missing_str(err, ["already exists", "duplicate"])
_LOGGER.warning(
"Index %s already exists on %s, continuing", index_name, table_name
Expand Down Expand Up @@ -213,7 +213,7 @@ def _add_columns(instance, table_name, columns_def):
)
)
return
except (InternalError, OperationalError):
except (InternalError, OperationalError, ProgrammingError):
# Some engines support adding all columns at once,
# this error is when they don't
_LOGGER.info("Unable to use quick column add. Adding 1 by 1")
Expand All @@ -229,7 +229,7 @@ def _add_columns(instance, table_name, columns_def):
)
)
)
except (InternalError, OperationalError) as err:
except (InternalError, OperationalError, ProgrammingError) as err:
raise_if_exception_missing_str(err, ["already exists", "duplicate"])
_LOGGER.warning(
"Column %s already exists on %s, continuing",
Expand Down