Skip to content

Fix Z-Wave lights#65638

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
alexanv1:zwave_light_fix
Feb 4, 2022
Merged

Fix Z-Wave lights#65638
MartinHjelmare merged 2 commits intohome-assistant:devfrom
alexanv1:zwave_light_fix

Conversation

@alexanv1
Copy link
Copy Markdown
Contributor

@alexanv1 alexanv1 commented Feb 4, 2022

Breaking change

Proposed change

With 2022.2 Z-Wave lights (using the deprecated integration) are failing with the below errors:

2022-02-04 00:09:13 ERROR (MainThread) [homeassistant.components.light] Error adding entities for domain light with platform zwave
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 382, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 514, in _async_add_entity
    capabilities=entity.capability_attributes,
  File "/usr/src/homeassistant/homeassistant/components/light/__init__.py", line 834, in capability_attributes
    if supported_features & SUPPORT_EFFECT:
TypeError: unsupported operand type(s) for &: 'NoneType' and 'int'
2022-02-04 00:09:13 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 382, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 514, in _async_add_entity
    capabilities=entity.capability_attributes,
  File "/usr/src/homeassistant/homeassistant/components/light/__init__.py", line 834, in capability_attributes
    if supported_features & SUPPORT_EFFECT:
TypeError: unsupported operand type(s) for &: 'NoneType' and 'int'

It's unclear why it's started failing all of a sudden (some Python setting changed to not ignore the error like previously?) but this change fixes it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@alexanv1 alexanv1 requested a review from a team as a code owner February 4, 2022 09:28
@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2022.2.2 milestone Feb 4, 2022
@MartinHjelmare MartinHjelmare merged commit 98a7125 into home-assistant:dev Feb 4, 2022
@alexanv1 alexanv1 deleted the zwave_light_fix branch February 4, 2022 10:26
balloob pushed a commit that referenced this pull request Feb 4, 2022
* Fix Z-Wave lights

* Update tests
@balloob balloob mentioned this pull request Feb 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants