Skip to content

Bump flux_led to 0.28.20#65621

Merged
frenck merged 1 commit intohome-assistant:devfrom
bdraco:flux_led_bump_20
Feb 4, 2022
Merged

Bump flux_led to 0.28.20#65621
frenck merged 1 commit intohome-assistant:devfrom
bdraco:flux_led_bump_20

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Feb 4, 2022

Proposed change

  • Fixes various bad assumptions about the protocol used for the 0x1A devices

Changelog: lightinglibs/flux_led@0.28.17...0.28.20

fixes lightinglibs/flux_led#147

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

- Fixes various bad assumptions about the protocol used for the 0x1A devices
@bdraco bdraco added this to the 2022.2.2 milestone Feb 4, 2022
@probot-home-assistant probot-home-assistant bot added bugfix dependency Pull requests marked as a dependency upgrade integration: flux_led small-pr PRs with less than 30 lines. labels Feb 4, 2022
@probot-home-assistant probot-home-assistant bot added dependency-bump Pull requests that update a dependency file by-code-owner labels Feb 4, 2022
@probot-home-assistant
Copy link
Copy Markdown

Hey there @icemanch, mind taking a look at this pull request as it has been labeled with an integration (flux_led) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck merged commit 7ab4214 into home-assistant:dev Feb 4, 2022
balloob pushed a commit that referenced this pull request Feb 4, 2022
@balloob balloob mentioned this pull request Feb 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix by-code-owner cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade dependency-bump Pull requests that update a dependency file integration: flux_led small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Christmas lights 0x1A / 0x10 (aka 6 LED Fairylights)

4 participants