Skip to content

Add WS API to adjust incorrect energy statistics#65147

Merged
balloob merged 6 commits intodevfrom
adjust_statistics
Mar 22, 2022
Merged

Add WS API to adjust incorrect energy statistics#65147
balloob merged 6 commits intodevfrom
adjust_statistics

Conversation

@emontnemery
Copy link
Copy Markdown
Contributor

@emontnemery emontnemery commented Jan 28, 2022

Proposed change

Add WS API recorder/adjust_sum_statistics which allows adjusting incorrect energy statistics.

The API accepts a statistic id (same as entity_id in most cases), a start time and an adjustment.

All statistics created at or later than the given start time is adjusted by the requested amount.

Note that no unit conversion is done; the adjustment must be in the unit used by the database:

  • kWh for energy
  • m³ for gas

Example to adjust sum statistics for sensor.total_energy up by 7MWh, starting at midnight new year's eve:

{
    "type": "recorder/adjust_sum_statistics",
    "statistic_id": "sensor.total_energy",
    "start_time": "2022-01-01 00:00:00Z",
    "adjustment": 7000.0
}

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 28, 2022

We should make this a websocket API and have a frontend for it. This is not something a user should ever need to automate (we have other problems then)

@emontnemery emontnemery changed the title Add service to adjust incorrect energy statistics Add WS API to adjust incorrect energy statistics Jan 30, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 1, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@emontnemery
Copy link
Copy Markdown
Contributor Author

Not stale, waiting for frontend

@balloob balloob force-pushed the adjust_statistics branch from 4ba0019 to 79a91fa Compare March 22, 2022 19:56
@balloob balloob merged commit b5c5da9 into dev Mar 22, 2022
@balloob balloob deleted the adjust_statistics branch March 22, 2022 22:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants