Skip to content

Add missing Coinbase RATEs#65101

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
nicjansma:coinbase-rates
May 12, 2022
Merged

Add missing Coinbase RATEs#65101
MartinHjelmare merged 1 commit intohome-assistant:devfrom
nicjansma:coinbase-rates

Conversation

@nicjansma
Copy link
Contributor

Proposed change

Coinbase exposes the exchange rates they support querying at https://api.coinbase.com/v2/exchange-rates

I've compared this list to const.py and have added all missing RATEs.

I was unable to verify if all of these rates imply wallet support, so I did not make any changes to WALLETS.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: n/a
  • This PR is related to issue: n/a
  • Link to documentation pull request: n/a

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @TomBrien, mind taking a look at this pull request as it has been labeled with an integration (coinbase) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title Coinbase integration: Add missing RATEs Add missing Coinbase RATEs Jan 28, 2022
Copy link
Member

@TomBrien TomBrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for contributing to the project :)

@homeassistant
Copy link
Contributor

Hi @nicjansma,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label May 11, 2022
@TomBrien
Copy link
Member

This should be good to merge now the the CLA has been signed

@github-actions github-actions bot removed the stale label May 11, 2022
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 69a8232 into home-assistant:dev May 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2022
@nicjansma nicjansma deleted the coinbase-rates branch May 31, 2022 02:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants