Skip to content

Cleanup unifiprotect discovery name#64389

Merged
bdraco merged 1 commit intohome-assistant:devfrom
bdraco:protect_discovery_presentation
Jan 18, 2022
Merged

Cleanup unifiprotect discovery name#64389
bdraco merged 1 commit intohome-assistant:devfrom
bdraco:protect_discovery_presentation

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jan 18, 2022

Proposed change

Small improvement to how the discovery is presented.

  • Now using the short mac since its the only stable identifer
    when you have multiple cloud keys on the network using
    DHCP

Previous
Screen_Shot_2022-01-18_at_12_32_01

New
Screen Shot 2022-01-18 at 12 31 47

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

- Now using the short mac since its the only stable identifer
  when you have multiple cloud keys on the network using
  DHCP
@probot-home-assistant
Copy link
Copy Markdown

Hey there @briis, @AngellusMortis, mind taking a look at this pull request as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco merged commit 8aec26d into home-assistant:dev Jan 18, 2022
@bdraco bdraco deleted the protect_discovery_presentation branch January 18, 2022 22:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants