Skip to content

Add launch status sensor for launch_library#64382

Merged
ludeeus merged 1 commit intohome-assistant:devfrom
DurgNomis-drol:launch-library-status-sensor
Jan 18, 2022
Merged

Add launch status sensor for launch_library#64382
ludeeus merged 1 commit intohome-assistant:devfrom
DurgNomis-drol:launch-library-status-sensor

Conversation

@DurgNomis-drol
Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

Add a launch status sensor showing the status (Go/NoGo/In-flight/Hold or other reason). And if the in hold, show the reason as an attribute.

Right now the update interval is set at an hour, but should we consider making this more frequent, like half an hour instead? I have tested it local for some time now, and I have not run into any problems with it being at half an hour. As this sensor benefits a lot from more frequent updates.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @ludeeus, mind taking a look at this pull request as it has been labeled with an integration (launch_library) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ludeeus ludeeus merged commit 57bcddb into home-assistant:dev Jan 18, 2022
@DurgNomis-drol DurgNomis-drol deleted the launch-library-status-sensor branch January 18, 2022 21:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants