Add entity options to entity registry#64350
Merged
emontnemery merged 3 commits intodevfrom Jan 18, 2022
Merged
Conversation
30 tasks
22 tasks
balloob
reviewed
Jan 18, 2022
balloob
reviewed
Jan 18, 2022
balloob
approved these changes
Jan 18, 2022
balloob
reviewed
Jan 18, 2022
| name: str | None | UndefinedType = UNDEFINED, | ||
| new_entity_id: str | UndefinedType = UNDEFINED, | ||
| new_unique_id: str | UndefinedType = UNDEFINED, | ||
| options: Mapping[str, Any] | UndefinedType = UNDEFINED, |
Member
There was a problem hiding this comment.
let's move this to a new method, update_entity_options(domain, options)
Contributor
|
Would this functionality add the possibility to have for example calibration values as entity options. Also, would this make #64315 redundant ? |
Contributor
Author
|
@droberg I think an option for configuring the wanted precision would be a welcome addition for sensor, not sure how well that maps to the resolution options for the Maxim DS18B20 though. |
63 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add entity options to entity registry.
This could for example be the wanted unit of a sensor or weather entity, the minimum brightness of a light or the maximum volume of a speaker.
Entity options should be indexed by domain, e.g.
options["light"]["minimum_brightness"]A new helper method for setting options,
EntityRegistry.async_update_entity_options, is added to the entity registry.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: