Skip to content

Fix situation where 'model' can be None (string) in Overkiz#64320

Merged
bdraco merged 1 commit intohome-assistant:devfrom
iMicknl:overkiz/fix_model
Jan 19, 2022
Merged

Fix situation where 'model' can be None (string) in Overkiz#64320
bdraco merged 1 commit intohome-assistant:devfrom
iMicknl:overkiz/fix_model

Conversation

@iMicknl
Copy link
Copy Markdown
Member

@iMicknl iMicknl commented Jan 17, 2022

Proposed change

(part of https://github.com/home-assistant/core/pull/64092/files split over multiple PR's)

During the strict mypy work, we maked sure that model would always be string, however I didn't notice that self.executor.select_state can return None in some situations where we fallback to the widget.
This widget is an Enum, which was also not used correctly.

Same situation for the sw_version.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bdraco bdraco merged commit 394c685 into home-assistant:dev Jan 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants