Skip to content

Add camera play stream support to roku#64153

Merged
ctalkington merged 15 commits intodevfrom
ctalkington-roku-play-stream
Jan 19, 2022
Merged

Add camera play stream support to roku#64153
ctalkington merged 15 commits intodevfrom
ctalkington-roku-play-stream

Conversation

@ctalkington
Copy link
Copy Markdown
Contributor

@ctalkington ctalkington commented Jan 15, 2022

Breaking change

Proposed change

Allows users with camera and stream setup to cast to roku using camera.play_stream over HLS streams.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@ctalkington
Copy link
Copy Markdown
Contributor Author

ctalkington commented Jan 15, 2022

@lvcabral have you noticed a need to specify videoFormat (hls or mp4) with HLS from camera? have you tried it with playonroku?

https://developer.roku.com/docs/developer-program/getting-started/architecture/content-metadata.md#playback-configuration-attributes is what i based the MediaType possible values on. (StreamFormat) it seems it defaults to "H.264/AAC in .mp4" but in a few tests it seemed to auto handle with no MediaType set. can you try with your media sources and see what behavior you get. would it be best to just pass "hls" either way?

@ctalkington ctalkington marked this pull request as ready for review January 15, 2022 08:12
@ctalkington
Copy link
Copy Markdown
Contributor Author

going to just go with always specifying "hls" here because that's the format we are getting from stream.

@ctalkington ctalkington requested a review from bdraco January 17, 2022 17:55
@lvcabral
Copy link
Copy Markdown

going to just go with always specifying "hls" here because that's the format we are getting from stream.

I think is a good decision, If you do not tell Roku what is the type it normally figure it out, but I noticed for hls it does not always work if you do not specify the type.

@ctalkington ctalkington merged commit 1421797 into dev Jan 19, 2022
@ctalkington ctalkington deleted the ctalkington-roku-play-stream branch January 19, 2022 04:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants