Cleanups in Twinkly code#64139
Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom Jan 14, 2022
Merged
Conversation
|
Hey there @dr1rrb, mind taking a look at this pull request as it has been labeled with an integration ( |
| ) | ||
|
|
||
| for key, value in device_info.items(): | ||
| if key not in HIDDEN_DEV_VALUES: |
Member
There was a problem hiding this comment.
Do we know all the keys that may exist in device_info? We want to see what they are and their formatting. Can we invert this check and list the allowed keys explicitly?
Contributor
Author
There was a problem hiding this comment.
I saw your comment about that as well in #42103. At the moment I have no clue what's in there. It needs some more digging. I would propose to address that separatly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Key
hostis removed from the (extra) state attribute of the light entity.Proposed change
Addresses the review comments in #62337 and #42103
c.c. @MartinHjelmare (I think I got them all)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: