Skip to content

Add new sensors with translations to Overkiz, and fix minor bugs#64092

Closed
iMicknl wants to merge 7 commits intohome-assistant:devfrom
iMicknl:overkiz/improve_sensor_and_translations
Closed

Add new sensors with translations to Overkiz, and fix minor bugs#64092
iMicknl wants to merge 7 commits intohome-assistant:devfrom
iMicknl:overkiz/improve_sensor_and_translations

Conversation

@iMicknl
Copy link
Copy Markdown
Member

@iMicknl iMicknl commented Jan 13, 2022

Proposed change

If this is too big, I can split it up in multiple PR's, however since most of them are relatively small fixes I decided to couple them to not make a load of PR's. Would be good to have at least the bugs fixed.

  • Add missing buttons from custom component
  • Add missing sensors from custom component
  • Add missing binary sensor from custom component (left out due to typing issues before)
  • Translate sensors and use keys by default, instead of capitalizing them
  • Fix bug in device info 'model' where a Enum could be stringified
  • Fix bug in battery sensor where output was apparently a string (100 %) instead of int
  • Remove extra dot from translations

This will fix and finish all current platforms that are in dev for now, so that it is ready for next core release.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@iMicknl
Copy link
Copy Markdown
Member Author

iMicknl commented Jan 14, 2022

Discussed with @epenet to split it up in multiple PR's. Closing this one for now.

@iMicknl iMicknl closed this Jan 14, 2022
@tetienne tetienne deleted the overkiz/improve_sensor_and_translations branch January 14, 2022 10:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants