Skip to content

Remove unused serial number config entry data from Elgato#64035

Merged
MartinHjelmare merged 1 commit intodevfrom
frenck-2022-0144
Jan 13, 2022
Merged

Remove unused serial number config entry data from Elgato#64035
MartinHjelmare merged 1 commit intodevfrom
frenck-2022-0144

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Jan 13, 2022

Proposed change

The serial number stored in the config entry data, isn't used anywhere.
Thus this PR cleans it up.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck frenck changed the title Elgato refactoring; add base entity Remove unused serial number config entry data from Elgato Jan 13, 2022
@MartinHjelmare MartinHjelmare merged commit 754e291 into dev Jan 13, 2022
@MartinHjelmare MartinHjelmare deleted the frenck-2022-0144 branch January 13, 2022 12:17
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants