Skip to content

Simplify Overkiz coordinator (step 2) and address feedback#64028

Merged
MartinHjelmare merged 7 commits intohome-assistant:devfrom
iMicknl:overkiz/simplify_coordinator_step2
Jan 13, 2022
Merged

Simplify Overkiz coordinator (step 2) and address feedback#64028
MartinHjelmare merged 7 commits intohome-assistant:devfrom
iMicknl:overkiz/simplify_coordinator_step2

Conversation

@iMicknl
Copy link
Copy Markdown
Member

@iMicknl iMicknl commented Jan 13, 2022

Proposed change

As mentioned in review feedback #62640 (comment), the coordinator is too complex and hard to read. In previous PR we removed some parts, in this PR we will implement the Registry() helper as suggested.

Not sure if this is the right way with passing self, however we need access to our data coordinator class variables

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Contributor

@tetienne tetienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice cleanup 💪

Comment on lines +137 to +139
for state in event.device_states:
device = self.devices[event.device_url]
device.states[state.name] = state
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We moved the logic 1:1, this is the only function that has been changed. Last PR's we really made it complicated to pass mypy, but now it was possible to simplify this and keep 100% mypy strict.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MartinHjelmare MartinHjelmare merged commit 105a7e5 into home-assistant:dev Jan 13, 2022
@iMicknl iMicknl deleted the overkiz/simplify_coordinator_step2 branch January 13, 2022 12:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants