Simplify Overkiz coordinator (step 2) and address feedback#64028
Merged
MartinHjelmare merged 7 commits intohome-assistant:devfrom Jan 13, 2022
Merged
Simplify Overkiz coordinator (step 2) and address feedback#64028MartinHjelmare merged 7 commits intohome-assistant:devfrom
MartinHjelmare merged 7 commits intohome-assistant:devfrom
Conversation
|
Hey there @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration ( |
iMicknl
commented
Jan 13, 2022
Comment on lines
+137
to
+139
| for state in event.device_states: | ||
| device = self.devices[event.device_url] | ||
| device.states[state.name] = state |
Member
Author
There was a problem hiding this comment.
We moved the logic 1:1, this is the only function that has been changed. Last PR's we really made it complicated to pass mypy, but now it was possible to simplify this and keep 100% mypy strict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
As mentioned in review feedback #62640 (comment), the coordinator is too complex and hard to read. In previous PR we removed some parts, in this PR we will implement the
Registry()helper as suggested.Not sure if this is the right way with passing
self, however we need access to our data coordinator class variablesType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: