Add play media URL support to roku#64021
Merged
ctalkington merged 14 commits intodevfrom Jan 15, 2022
Merged
Conversation
probot-home-assistant
Bot
added
integration: roku
new-feature
small-pr
This comment has been minimized.
This comment has been minimized.
ctalkington
changed the title
ctalkington
changed the title
8 tasks
ctalkington
changed the title
decompil3d
approved these changes
Jan 14, 2022
bdraco
reviewed
Jan 15, 2022
| extra: dict[str, Any] = kwargs.get(ATTR_MEDIA_EXTRA) or {} | ||
|
|
||
| if media_type not in (MEDIA_TYPE_APP, MEDIA_TYPE_CHANNEL): | ||
| if media_type not in (MEDIA_TYPE_APP, MEDIA_TYPE_CHANNEL, MEDIA_TYPE_URL): |
Member
There was a problem hiding this comment.
It probably doesn't matter here but you could make this a constant and then unpack it below with a *
Contributor
Author
There was a problem hiding this comment.
will address in other PR
bdraco
reviewed
Jan 15, 2022
bdraco
approved these changes
Jan 15, 2022
ctalkington
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: