Skip to content

Improve UniFi Protect Smart Sensor support#64019

Merged
bdraco merged 6 commits intohome-assistant:devfrom
AngellusMortis:ufp-sense-improvements
Jan 13, 2022
Merged

Improve UniFi Protect Smart Sensor support#64019
bdraco merged 6 commits intohome-assistant:devfrom
AngellusMortis:ufp-sense-improvements

Conversation

@AngellusMortis
Copy link
Copy Markdown
Contributor

@AngellusMortis AngellusMortis commented Jan 13, 2022

Proposed change

Adds missing sensor entities for the Smart Sensor device, all except the leak sensor since the leak accessory has not been released yet. New entities:

  • Alarm Sound and Tampering binary sensors
  • Motion Sensitivity number
  • Mount Type and Paired Camera selects
  • Status Light switch
  • Configuration switches for various sensors:
    • Motion Detection switch
    • Temperature Sensor switch
    • Humidity Sensor switch
    • Light Sensor switch
    • Alarm Sound Detection switch

The UniFi Protect Smart Sensor is a bit different than other devices. The sensors it provides is based on how you configure it. After a lot of discussion, we felt like the best way to handle this is just mark the sensors not configured as unavailable. Since they can be enabled via the switch entities provided, that seemed like the best solution instead of adding/removing them or enabling/disabling them, both of which requires a config entry reload.

Changelog for pyunifiprotect bump: https://github.com/briis/pyunifiprotect/releases/tag/v1.6.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @briis, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Co-authored-by: J. Nick Koston <nick@koston.org>
@bdraco bdraco merged commit 2076817 into home-assistant:dev Jan 13, 2022
@bdraco bdraco deleted the ufp-sense-improvements branch January 13, 2022 03:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants