Improve UniFi Protect Smart Sensor support#64019
Merged
bdraco merged 6 commits intohome-assistant:devfrom Jan 13, 2022
AngellusMortis:ufp-sense-improvements
Merged
Improve UniFi Protect Smart Sensor support#64019bdraco merged 6 commits intohome-assistant:devfrom AngellusMortis:ufp-sense-improvements
bdraco merged 6 commits intohome-assistant:devfrom
AngellusMortis:ufp-sense-improvements
Conversation
|
Hey there @briis, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
added 2 commits
January 12, 2022 20:47
bdraco
reviewed
Jan 13, 2022
bdraco
reviewed
Jan 13, 2022
bdraco
reviewed
Jan 13, 2022
Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco
reviewed
Jan 13, 2022
bdraco
approved these changes
Jan 13, 2022
bdraco
approved these changes
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds missing sensor entities for the Smart Sensor device, all except the leak sensor since the leak accessory has not been released yet. New entities:
The UniFi Protect Smart Sensor is a bit different than other devices. The sensors it provides is based on how you configure it. After a lot of discussion, we felt like the best way to handle this is just mark the sensors not configured as unavailable. Since they can be enabled via the switch entities provided, that seemed like the best solution instead of adding/removing them or enabling/disabling them, both of which requires a config entry reload.
Changelog for pyunifiprotect bump: https://github.com/briis/pyunifiprotect/releases/tag/v1.6.3
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: