Skip to content

Add type hints to media_player (part 1)#64005

Merged
epenet merged 2 commits intohome-assistant:devfrom
epenet:setup-type-hint-media-player
Jan 13, 2022
Merged

Add type hints to media_player (part 1)#64005
epenet merged 2 commits intohome-assistant:devfrom
epenet:setup-type-hint-media-player

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Jan 12, 2022

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@epenet epenet requested a review from ctalkington as a code owner January 12, 2022 22:12
media_content_id: str,
media_image_id: str | None = None,
) -> tuple[str | None, str | None]:
) -> tuple[bytes | None, str | None]:
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the type hint here was previously wrong.

@epenet epenet merged commit 5cd7317 into home-assistant:dev Jan 13, 2022
@epenet epenet deleted the setup-type-hint-media-player branch January 13, 2022 09:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants