Add setup type hints to rfxtrx#63963
Conversation
|
Hey there @Danielhiversen, @elupus, @RobBie1221, mind taking a look at this pull request as it has been labeled with an integration ( |
| def _constructor( | ||
| event: rfxtrxmod.RFXtrxEvent, | ||
| auto: bool, | ||
| auto: rfxtrxmod.RFXtrxEvent | None, |
There was a problem hiding this comment.
This did not correspond to the hint defined in __init__.py
I think the __init__.py method should be adjusted to pass a bool, but that would be a code change and it seemed safer to adjust the type hint instead to match the current arguments.
core/homeassistant/components/rfxtrx/__init__.py
Lines 249 to 252 in 67c3565
and
There was a problem hiding this comment.
The second event is a auto detected event. So this change is correct. A refactor for auto might be in order later.
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: