Import persistent notification (part 5)#63902
Merged
emontnemery merged 1 commit intodevfrom Jan 13, 2022
Merged
Conversation
|
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
epenet
approved these changes
Jan 11, 2022
Contributor
epenet
left a comment
There was a problem hiding this comment.
Code LGTM - just a small note about the tests
| TYPE_AUTH_REQUIRED, | ||
| ) | ||
| from homeassistant.components.websocket_api.const import URL | ||
| from homeassistant.const import SIGNAL_BOOTSTRAP_INTEGRATONS |
Contributor
There was a problem hiding this comment.
I'm not sure why this change slipped into this PR
Contributor
Author
There was a problem hiding this comment.
The constant was moved in part1 (#63898) to fix a circular import, this just updates the import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Import
persistent_notification(part 5)By importing instead of accessing via
hass.components, type checking etc. works correctlyType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: