Discord connect fix

[Deinara]

Description:

Sorry that this has taken so long for me to create a pull request for, but this has cost me several nights of messing around.

Related issue (if applicable): fixes #5688

Pull request in home-assistant.github.io with documentation (if applicable):
Not applicable - same as original

Example entry for configuration.yaml (if applicable):

Not applicable - same as original

Checklist:

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.github.io --No changes--

If the code communicates with devices, web services, or third-party tools:

• Local tests with tox run successfully. Your PR cannot be merged unless tests pass
• New dependencies have been added to the REQUIREMENTS variable (example). --No changes--
• New dependencies are only imported inside functions that use them (example). --No changes--
• New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py. --No changes--
• New files were added to .coveragerc. --No changes--

[mention-bot]

@Deinara, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pvizeli and @fabaff to be potential reviewers.

[homeassistant]

Hello @Deinara,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

• a444df3fdea41cb8be7e80a71c12832a830b501f - This commit has something that looks like an email address (christiaan.blom@mail.com). Maybe try linking that to GitHub?.
• b038a1650e96773ecea7e9378b8e445f3cec676a - This commit has something that looks like an email address (christiaan.blom@mail.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

   • If you only made a single commit you should be able to run

     git commit --amend --author="Author Name <email@address.com>"
     

     (substituting Author Name and email@address.com for your actual information) to set the authorship information.
   • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
     1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
     2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
   • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

[Deinara]

Added the email used for the commits to my account to resolve the cla-error

[homeassistant]

Hi @Deinara,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[Deinara]

Could anyone provide me any guidance on the "Unused variable 'on_ready'"-error?
It's definitely being used, as I'm redefining a function from a different class, but Flake doesn't detect that.

[balloob]

Linter complaints because the defined function on_ready is not being used. Unless it is automatically registered by applying the annotation @discord_bot.event. If that is the case, add # pylint: disable=unused-variable above it.

[balloob]

Is close not needed anymore?

[Deinara]

The following is taken from the API reference:

logout()
This function is a coroutine.
Logs out of Discord and closes all connections.

close()
This function is a coroutine.
Closes the connection to discord.

After thinking about it, this indicated to me close() is not required. I could add it 'just to be sure'.

The on_ready() function is called by discord_bot.start() and is automatically registered. I'll add the pylint line as suggested. Thanks.

[homeassistant]

Hello @Deinara,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

• 6b313aacd2833d5fb7382ed21386a3733b2d1a14 - This commit has something that looks like an email address (christiaan.blom@gmail.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

   • If you only made a single commit you should be able to run

     git commit --amend --author="Author Name <email@address.com>"
     

     (substituting Author Name and email@address.com for your actual information) to set the authorship information.
   • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
     1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
     2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
   • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

[houndci-bot]

block comment should start with '# '

[houndci-bot]

at least two spaces before inline comment

[Deinara]

To recap:
I've reviewed more code examples, I'm keeping close() in for now.
I've pushed a commit created with an invalid email address, so I've rolled that commit back, changed the email, and pushed it again. The CLA-error didn't automatically go away though.

[robbiet480]

Thanks! 🐬 🍪 💯