Skip to content

Remove warnings from compensation#63691

Merged
frenck merged 1 commit intohome-assistant:devfrom
Petro31:fix-numpy-raise-all-warnings
Jan 13, 2022
Merged

Remove warnings from compensation#63691
frenck merged 1 commit intohome-assistant:devfrom
Petro31:fix-numpy-raise-all-warnings

Conversation

@Petro31
Copy link
Copy Markdown
Contributor

@Petro31 Petro31 commented Jan 8, 2022

Breaking change

Proposed change

Fixes

Using warnings is not thread safe so it must be removed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title remove warnings from compensation Remove warnings from compensation Jan 8, 2022
@frenck frenck merged commit 5f9a351 into home-assistant:dev Jan 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2022
@Petro31 Petro31 deleted the fix-numpy-raise-all-warnings branch May 1, 2025 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The compensation integration changes the warnings filter

4 participants