Add daily weather forecasts to Open-Meteo integration#63677
Merged
Conversation
probot-home-assistant
bot
added
integration: open_meteo
new-feature
by-code-owner
labels
jsherman256
approved these changes
Jan 9, 2022
| forecasts: list[Forecast] = [] | ||
| for index, time in enumerate(self.coordinator.data.daily.time): | ||
| forecast = Forecast( | ||
| datetime=time.isoformat(), |
Contributor
There was a problem hiding this comment.
Do timezones need to be accounted for here?
Member
Author
There was a problem hiding this comment.
It already has been accounted for, see the initialization in the unit file
avee87
reviewed
Jan 17, 2022
| ) | ||
|
|
||
| if daily.weathercode is not None: | ||
| forecast["condition"] = WMO_TO_HA_CONDITION_MAP.get( |
Contributor
There was a problem hiding this comment.
Shouldn't this be forecast[ATTR_FORECAST_CONDITION] and such?
See https://github.com/home-assistant/core/blob/dev/homeassistant/components/weather/__init__.py#L42-L50
Member
Author
There was a problem hiding this comment.
I don't think there is much benefit from that, as it already is a typed dictionary.
The reason we used constants in the past, is mostly to reduce typos, which are now already guarded.
balloob
approved these changes
Jan 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add daily forecasting to the Open-Meteo integration.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: